Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re

On Sun, 3 Aug 2008, Pierre Joye wrote: > On Sun, Aug 3, 2008 at 5:51 PM, Derick Rethans <derick@php.net> wrote: > > On Sat, 2 Aug 2008, Pierre-Alain Joye wrote: > > > >> pajoye Sat Aug 2 16:49:56 2008 UTC > >> > >> Modified files: > >> /php-src/ext/date config.w32 > >> /php-src/ext/date/lib parse_iso_intervals.re > >> Log: > >> - improve previous fix for scan, disable optimizer only for scan() using #pragma > >> optimize > > > > This is non-sense. The scan function in parse_iso_intervals.c is only > > 750 lines long, while the scan function in parse_date.c is 21000 lines > > long. And there is no problem with the latter function. If you want to > > work around bugs in compilers, then stick that in the config.w32 file - > > I don't want silly windows only defines in the code. > > Asking to support 10 years old compiler and SDK and at the same time > reject fixes for them do not make sense to me. However it is barely > relevant, your code is in core, part of the standard feature and is > always enabled, it must work for windows as well (and that means VC6 > and VC9 support). you're not reading what I said. It does not make one single bit of sense that a short function gives problems while an enormously long function is fine. This does *NOT* make sense. If you have no idea either, then figure it out first before you add silly #pragmas to code. THis sort of stuff should be handled in the build system anyway with flags to the compiler for this specific file. I prefer to revert it so that the whole ext misses out the optimizations for old compilers. If we then later find out what really causes it we can add that work around. Now it feels like it's added for just "let's hack around things to make it work while I have no idea why this hack works". regards, Derick -- HEAD before 5_3!: http://tinyurl.com/6d2esb http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org