Re: [VOTE] 64 bit platform improvements for string length and integer

On Fri, Jan 31, 2014 at 6:00 AM, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > Testing the performance implications of this patch compared to 5.5.8 > as listed on the wiki makes no sense. It does. The delta are the same if you use 5.6 (as stated many times here). Check out what the patch actually does. > I am saying if you want to publish impact results of this patch then > you must test PHP5.6.0-alpha#1 zts/nts with/without this patch. > Any other comparison is testing apples against melons and melons > against potatoes. The correct quote is apples vs pears, but that's a bit off topic. However by the time the RFC moved to the voting phase (the preparation), it was not possible from a time manner to do these tests, that has changed since. > Lets set away your incorrect fact about "extension developers can just > focus on compat with 5.6+" in 2 years time, and focus on your point: > All extensions have X as lowest supported version, hopefully being 5.6. Yes, as it was always the case, I am not sure to follow you here. What is the point exactly? > Just because 5.6 is the "base versions" the extension support, you > will still be using that compat header and workarounds because you, or > anyone else, is not stupid enough to change all these lines of code > for absolutely no gain. > > (PHP_NEED_STRSIZE_COMPAT ? "Os|al" : "OS|ai") is the way you will be > passing arguments to zpp from now on. It seems that you did not carefully read the RFC, especially the available options. There are options to avoid exactly that. Cheers, -- Pierre @pierrejoye | http://www.libgd.org