Re: [VOTE] 64 bit platform improvements for string length and integer

From: Date: Sat, 01 Feb 2014 19:11:51 +0000
Subject: Re: [VOTE] 64 bit platform improvements for string length and integer
References: 1 2 3 4 5 6  Groups: php.internals 
Request: Send a blank email to internals+get-71930@lists.php.net to get a copy of this message
On Sat, 2014-02-01 at 19:35 +0100, Pierre Joye wrote: > It is not, there is no change from user level but on windows and a 1-2 > other platforms with long being 32 bit in 64bit. The current rule isn't precise, different interpretations are possible. I lean to the side that a big change to the APIs is comparable to a userland language change. I can see that this is read differently. > Also I find amazingly disturbing the amount of efforts you are putting > to shut down this RFC, without a single comment in the last months or > weeks, not even now to explain your vote. > > I do not mind a no, but what is happening here is disgusting, to say it nicely. Many contributors mentioned their concern about pushing in a patch changing more than 20,000 lines of code now. I haven't seen much critic on the implementation itself, simply the request for more time to a) review it to make sure there are no accidental errors from conversion and b) time to learn "the new way" before putting in a release, many have to relearn thins hardwired in the brain for more than 10 years, such adoption takes some time. Yes, we might have reviewed the branch sooner and learned the details sooner but we are lazy and holding back in investing time in "experimental" things. I think a good way to proceed is to put it in master now and leave it from 5.6. This forces everybody to look into it (and we will have lots of opportunity to learn due to merging pain [which we have when putting in 5.6, too]) and gives everybody enough time to adopt their brain and prepare pecl (and internal) exts. johannes

« previous php.internals (#71930) next »