Re: [VOTE] [RFC] 64 bit platform improvements for string length and integer

Dmitry Stogov <dmitry@zend.com> schrieb: > --bcaec548a66d12428804f9c0c7f7 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: quoted-printable > > We had a long discussion with Pierre on IRC and probably come to some > agreement. > However, we always talk as a blind with a deaf, so I can't be completely > sure :) > > We agreed to make 64-bit IS_LONG and 64-bit string length on all 64-bit > systems, but don't change other core data structures (as Nikita suggested). > > The main idea of the changes on top of phpng may be seen at > https://gist.github.com/dstogov/07fcbb60b1b585bcd290 > > I checked the patch on 64-bit Linux. The memory consumption grows, but no > so dramatic. On wordpress home page without opcache the peak_memory_usage() > showed 11043920 bytes insead of 10959456, that mean ~0.8% that we probably > can afford. Note that the original patch on the same test showed ~8% memory > consumption increase on master. > Sounds very good and 0.8% overhead is fine. Can we work on getting this integrated into a v2 of the RFC, continue hopefully constructive discussions for a week or two and then vote again. We aren't in a rush at the moment as php.next is far away.