Re: RE: [RFC] Fast Parameter Parsing API

On Tue, May 27, 2014 at 4:00 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > Hi! > >> No. You might want to return false (it's maybe not a good idea to do so, but it would >> break BC to remove that possibility) > > I think we need to use this opportunity to clean up our APIs. I.e. if > the functions return NULL when passed wrong parameters (which makes > sense), then *all* functions should do that, not just 99%, and random 1% > would return something else. > Yes, this means some (very minor) BC issues. We're doing a major > version, and I think this is acceptable price to pay for consistent API. I fully agree here. I would like to do the same with the quiet option, which is not that useful anyway. Btw, I did not check every function, but variable # of arguments seem to be far less used than fixed amount, that could open a door for a special case. Cheers, -- Pierre @pierrejoye | http://www.libgd.org