AW: Re[2]: [PEAR-DEV] Package Proposal: Payment_DTA, SOURCECODE
| From: | Stephan Schmidt | Date: | Wed, 20 Aug 2003 13:07:13 +0000 |
| Subject: | AW: Re[2]: [PEAR-DEV] Package Proposal: Payment_DTA, SOURCECODE | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20153@lists.php.net to get a copy of this message | ||
Hi
> I'm pleased that this package seems to be a good thing perhaps.
>
> You can find the sourcecode here:
>
> http://www.web-gear.com/test/dta/Dta.php.txt
Looks good. You have some tabs in your file, please replace them with
spaces.
The only thing I think is confusing is the addExchange() method as there are
a lot of optional parameters. Would be nice if you could provide a way to
hand over an array so if I'd like to add an additional name I do not have to
pass all the other parameters.
> Please note that this is my first time I make sourcecode of me public, so
> don't judge to hard :-). Each advice is welcome!
Next time, try renaming your file to Dta.phps, with most server
configurations you'll get a highlighted version of the code, makes it easier
to read....
To cut things short, I'm +1 for including this.
Stephan