Re: Package Proposal: Payment_DTA, SOURCECODE

From: Date: Wed, 20 Aug 2003 13:20:25 +0000
Subject: Re: Package Proposal: Payment_DTA, SOURCECODE
References: 1 2 3  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-20154@lists.php.net to get a copy of this message
Web-Gear wrote:
Hi! I'm pleased that this package seems to be a good thing perhaps. You can find the sourcecode here: http://www.web-gear.com/test/dta/Dta.php.txt Please note that this is my first time I make sourcecode of me public, so don't judge to hard :-). Each advice is welcome! I build this class for use in my portal original, because I didn't found anything like that. Now in my tests it has worked, and so I thougt it would be a good idea to put forward it here. You can find a test script here: http://www.web-gear.com/test/dta/test.php.txt
Looks great! The indentation on the comments need some small doing, and personally I´d prefer passing objects as parameters to addExchange(), so I could have code completion on the properties, but aside from that, it looks solid. +1 here. Regards, Markus

« previous php.pear.dev (#20154) next »