Re: Package Proposal: Payment_DTA, SOURCECODE

On 20 Aug 2003 at 15:20, Markus Wolff wrote: > Web-Gear wrote: > > > I'm pleased that this package seems to be a good thing perhaps. > > > > You can find the sourcecode here: > > > > http://www.web-gear.com/test/dta/Dta.php.txt > > > > Please note that this is my first time I make sourcecode of me > > public, so don't judge to hard :-). Each advice is welcome! > > > > I build this class for use in my portal original, because I didn't > > found anything like that. Now in my tests it has worked, and so I > > thougt it would be a good idea to put forward it here. > > > > You can find a test script here: > > > > http://www.web-gear.com/test/dta/test.php.txt > > Looks great! The indentation on the comments need some small doing, > and personally I´d prefer passing objects as parameters to > addExchange(), so I could have code completion on the properties, but > aside from that, it looks solid. > > +1 here. Agreed. Some tabs etc. as already mentioned are the only things that came into my mind while reviewing the source. The rest seems clean CS. Maybe the idea of Markus using objects could be discussed a bit further? But apart from that maybe minor change I like your proposal very much and already have use for it :-)) +1 from me. Stefan