Re: voting reminder - File_Palm_PDB
| From: | Greg Beaver | Date: | Wed, 27 Aug 2003 01:04:53 +0000 |
| Subject: | Re: voting reminder - File_Palm_PDB | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20597@lists.php.net to get a copy of this message | ||
Hi Krystof,
Initial notes:
CS issues:
all method names should be studly caps (first letter in lower case, otherwise you're fine)
The require_once in datebook.php and addrbook.php need to be require_once 'File/Palm/PDB.php' and require_once 'File/Palm/PDB.php' (or whatever the location will be - ../PDB.php will not work)
In addition, I think you should capitalize Datebook and Addrbook, unless you feel strongly that this will break functionality.
Fix these minor things and I will vote :)
Thanks,
Greg
Krystof Slaby wrote:
hello, I'd like to remind you with voting for the File_Palm_PDB package. AS the name tells it would end in File category. PDB is format of Palm DB databases stored outside PalmOS (PCs mainly). The class is does lower-level IO (reads/writes the 'database') and the extending classes do higher-level stuff - like those for addressbook (Address internal app) or datebook (DateBook internal app) or PalmDOC (palm text 'file' format). Most of the sources will be available at http://camelot.lf2.cuni.cz/krysot/krysot/php-pdb/. Up to now, the score is: +1 from Jesus M. Castagnetto +1 from Jan Schneider Back from vacation - a lot to do. But I'd like to publish it in PEAR anyway - awaitig +1/comments. krysot