Re: voting reminder - File_Palm_PDB

From: Date: Wed, 27 Aug 2003 13:39:46 +0000
Subject: Re: voting reminder - File_Palm_PDB
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-20637@lists.php.net to get a copy of this message
On 26 Aug 2003 at 21:04, Greg Beaver wrote: > Initial notes: > > CS issues: > > all method names should be studly caps (first letter in lower case, > otherwise you're fine) > > The require_once in datebook.php and addrbook.php need to be > require_once 'File/Palm/PDB.php' and require_once 'File/Palm/PDB.php' > (or whatever the location will be - ../PDB.php will not work) > > In addition, I think you should capitalize Datebook and Addrbook, > unless you feel strongly that this will break functionality. > > Fix these minor things and I will vote :) Agreed. When some minor issues (that Greg pointed out) are fixed I'm also willing to vote for this. Having access to a PDB-file might be quite handy - so I love to see that somebody included support for that. Stefan

« previous php.pear.dev (#20637) next »