Re: voting reminder - File_Palm_PDB
| From: | Bertrand Mansion | Date: | Wed, 27 Aug 2003 13:57:00 +0000 |
| Subject: | Re: voting reminder - File_Palm_PDB | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20639@lists.php.net to get a copy of this message | ||
<greg@chiaraquartet.net> wrote :
> Hi Krystof,
>
> Initial notes:
>
> CS issues:
>
> all method names should be studly caps (first letter in lower case,
> otherwise you're fine)
>
> The require_once in datebook.php and addrbook.php need to be
> require_once 'File/Palm/PDB.php' and require_once 'File/Palm/PDB.php'
> (or whatever the location will be - ../PDB.php will not work)
>
> In addition, I think you should capitalize Datebook and Addrbook, unless
> you feel strongly that this will break functionality.
>
> Fix these minor things and I will vote :)
>
> Thanks,
> Greg
Hi Krystof, I'd add :
- remove ; after your }
- remove deprecated methods
- remove comments with lots of =============
And I'll vote as well :)
Thanks,
Bertrand Mansion
Mamasam