Re: Package Proposal : Archive_Zip

Thanks for all the feedback I received about Archive_Zip. I will add a package Archive_Zip and modify the PclZip source code in order to be compliant with PEAR Coding Standards (doc, private methods, ...) and the team proposals (parameters send by arrays, ...). Regards, Vincent ----- Original Message ----- From: "Lukas Smith" <smith@backendmedia.com> To: "'Vincent Blavet'" <vincent@phpconcept.net>; <pear-dev@lists.php.net> Sent: Thursday, September 11, 2003 7:03 PM Subject: RE: [PEAR-DEV] Package Proposal : Archive_Zip > > From: Lukas Smith [mailto:smith@backendmedia.com] > > Sent: Tuesday, September 02, 2003 12:06 AM > > To: 'Vincent Blavet'; pear-dev@lists.php.net > > Subject: RE: [PEAR-DEV] Package Proposal : Archive_Zip > > > > > From: Vincent Blavet [mailto:vincent@phpconcept.net] > > > Sent: Tuesday, September 02, 2003 12:03 AM > > > > > What don't you like exactly in the PclZip API ? The use of variable > > > parameters like > > > arch->extract(PCLZIP_OPT_PATH, "folder", > > > PCLZIP_OPT_REMOVE_ALL_PATH); ? > > > > > > If yes, how do you think is the best solution when you have lots of > > > available way to extract (by name, by index, by reg-exp, ...), > define > > a > > > method per way ? a method per options (remove path, add path, ...) ? > > Use > > > flags in the class object ? ... > > > Thanks for any input. > > > > > > (BTW I'm not sure I like the idea to rewrite a lot of PclZip code > > ....) > > > > I will take another look at the class and I will get back to you. > > Ok took a bit longer than I had planned. > > Anyways I took another look at pclzip 2.0. > > I guess aside from the obvious CS differences that need to be fixed I > only have two little comments: > - try to limit the characters per line to 80 > - try and see if you can cut down the number of parameters to 3 in some > of the methods .. I think often it is preferable to move to arrays > instead of having so many parameters (I know that I haven't hit that > mark in MDB in a lot of places either) > > otherwise I am +1 on having the package :-) > > Regards, > Lukas > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >