Re: [Call for Votes] HTTP_Download
| From: | Jon Parise | Date: | Wed, 01 Oct 2003 17:55:17 +0000 |
| Subject: | Re: [Call for Votes] HTTP_Download | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-22274@lists.php.net to get a copy of this message | ||
On Wed, Oct 01, 2003 at 07:34:30PM +0200, Michael Wallner wrote:
> If there are no more suggestions/comments I would like to call
> for voting on the package HTTP_Download.
>
> http://dev.iworks.at/PEAR/HTTP_Download/
I'm not sure I like the die() call in the constructor.
> I've got one +1 by schst, but I don't know if this still counts,
> Stephan?
Your brace placement needs a little work in order to comply with the
coding standards. The one-true-brace style looks like this:
function setParamas($params)
{
if (something) {
statement;
}
}
The code would also benefit from a bit more vertical whitespace.
Looks good otherwise.
--
Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)