Re: [Call for Votes] HTTP_Download
| From: | Michael Wallner | Date: | Wed, 01 Oct 2003 18:03:11 +0000 |
| Subject: | Re: [Call for Votes] HTTP_Download | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-22275@lists.php.net to get a copy of this message | ||
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jon Parise, you wrote:
> I'm not sure I like the die() call in the constructor.
Well, what would you suggest?
> Your brace placement needs a little work in order to comply
> with the coding standards. The code would also benefit from a
> bit more vertical whitespace.
Updated :)
> Looks good otherwise.
Thanks,
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (Cygwin)
iD8DBQE/exbe3645gzRPvy8RAq1sAJ9b85s3uWu9Isi/EAfKQ2pbowPc7gCgiH+R
xPP0tiJ5FrAg0yZRILI5ojc=
=G0BA
-----END PGP SIGNATURE-----