strtolower on get_class in toString (was: DB run tests)
| From: | Daniel Convissor | Date: | Thu, 29 Apr 2004 17:54:22 +0000 |
| Subject: | strtolower on get_class in toString (was: DB run tests) | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-28569@lists.php.net to get a copy of this message | ||
Sire:
On Thu, Apr 29, 2004 at 07:37:19PM +0200, Lukas Smith wrote:
>
> maybe ... or add strtolower() .. however its sort of a pity to add the
> strotolower() into toString() .. so just do the strtolower() in the test?
Why is it a pitty to add strtolower()? It adds compatibility between
PHP's 4 and 5 for applications. I've seen you wanting to remove this from
DB_common::toString(). Anyway, strtolower() is already in
DB_common::toString(). The test is failing due to PEAR_Error::toString().
Personally, I feel it too should have strtolower() wrapping the
get_class($this) call.
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409