Re: strtolower on get_class in toString

From:	Lukas Smith	Date:	Thu, 29 Apr 2004 18:26:00 +0000
Subject:	Re: strtolower on get_class in toString
References:	1 2 3 4 5 6 7 8 9 10	Groups:	php.pear.dev
Request:	Send a blank email to pear-dev+get-28570@lists.php.net to get a copy of this message

Daniel Convissor wrote:

Sire: On Thu, Apr 29, 2004 at 07:37:19PM +0200, Lukas Smith wrote:
maybe ... or add strtolower() .. however its sort of a pity to add the strotolower() into toString() .. so just do the strtolower() in the test?
Why is it a pitty to add strtolower()? It adds compatibility between PHP's 4 and 5 for applications. I've seen you wanting to remove this from DB_common::toString(). Anyway, strtolower() is already in DB_common::toString(). The test is failing due to PEAR_Error::toString(). Personally, I feel it too should have strtolower() wrapping the get_class($this) call.

to me the purpose of toString is to provide a string to be outputed for human consumption and not to enable testing. For humans the mixed case is a plus. regards, Lukas Smith smith@backendmedia.com _______________________________ BackendMedia www.backendmedia.com berlin@backendmedia.com Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07