Re: Re: [PEPr] Comment on RFC::ProtectedMembers

Lukas Smith wrote:

Hans_L wrote:

Private var prefixing should definitely be left up to the author. It affects absolutely no one else.

Hans you seem to have a serious misunderstanding of the reason we have a CS: the reason is that we want to make it easy for anybody to poke around in the code if necessary to submit patches, help out, do a security audit or take over an orphaned package. This is why the CS covers stuff that goes way beyond just the public API.

Yes, perhaps I do have a misunderstanding. I do think PEAR CS requirements are a bit too strict, but of course that's not really the topic of this thread. I felt that private var naming should be up to authors because for some libraries it will be the assumed standard, and as we've all agreed PHP5 no longer requires any visual reminders for users. I don't see the benefit in making it a requirement, that's all. I can't imagine it actually making it easier for someone to submit a patch. I have no trouble following design of PHPUnit2, for example, which does not use any such convention. I know it's hard, but c'mon people let it go; this PHP4 coding convention just is not necessary in PHP5. Hans