Re: PEPr Automated Verification Process - firstenhancements

On Sun, 19 Jun 2005 10:01:55 +0800 alan@akbkhome.com (Alan Knowles) wrote: > On Sat, 2005-06-18 at 18:14 +0200, Stefano F. Rausch wrote: > > Dear PEAR-Devs, > > > > Tobias and I would like to inform you that some of the > > enhancements regarding the PEPr process have been committed to > > cvs. > > > > What follows is a detailed description of the changes: > > + > > + case 'pkg_source': > > + return preg_match('"^http\://.+\.(phps|htm(l)?) > > $"', $url)? true: false; > or .txt I guess... - if you dont run .phps on your server, > uploading a php file as a .txt, at least get's it rendered... > it also rules out people doing stuff like > 'http://myapplication/render?name=somefile/xyz.php' I do not see a reason to force file extensions. Can you explain me why? > I'd rather you have a series of blank options > > [---type---V] [url] > [---type---V] [url] > [---type---V] [url] > [---type---V] [url] > + a message say what is required.. > > then check that all the required types have been added... (eg. > like source url / example url etc...) Much more easier. We only have to check if the required types are present, not if the url is a phps html or whatever else. > I always wonder if we should allow comments on draft proposals - > it would save alot of time for the proposers trying to come up > with a proposal that may never be accepted... Agreed. --Pierre