Re: [PEPr] Proposal for HTML::AJAX

Joshua Eichorn wrote:

Laurent Laville wrote:

Joshua Eichorn wrote:

Joshua Eichorn wrote:

Joshua Eichorn (http://pear.php.net/user/jeichorn) proposes HTML::AJAX. You can find more detailed information here: http://pear.php.net/pepr/pepr-proposal-show.php?id=276

With today's addition this package should be pretty much ready to vote on. There is still more development I'd like to work on, the main areas being, integrating behaviors into the js library (apply ajax using css classes instead of onclick call), and some baseline widget work. I'll also look into integrating with other effect libraries such as script.aculo.us but this might end up just being a guide on howto do it. Serialization wise i'd like to add a JPSpan xml serializer as well as one that instanciates real classes and sets properties on those (though security is a concern with this). The PHP JSON code needs to be pulled out in its own project, but im sure Michal Migurski will have his proposal accepted before I reach stable, even if that means I have to help him get his code fully pearified. Anyhow thats all stuff I'd like to get done before 1.0 but I don't see it standing in the way of a call for votes. If anyone sees anything im missing let me know, otherwise i'll do a call for votes next week. -josh

Hello Joshua, I'm a beginner with AJAX, but i want to learn, and i think this proposal will be a good add to community. I've then first to read your source code and run examples (online, and offline: localhost). My first review of source code: 1.You need to fix all your function declaration following coding standard http://pear.php.net/manual/en/standards.funcdef.php

Any place in particular, I thought I had them everywhere but in the JSON class which is going away soon when its released as Services_JSON

well i wanted just to say : function foo() { } rather than, as you wrote, function foo() { }

2.Fix some whitespaces/tabs (identation)

I guess missed adding the vim hints to some files i'll get this cleaned up

3.about HTML/AJAX/Server.php clientJsLocation() perharps it could be better to use DIRECTORY_SEPARATOR constant rather than just '/' depending of platform.

good point

My first attempt to run the demos. 1. proxyless_usage.php do nothing, except the clear target

Odd does the proxy example work

i got same error as for proxy_usage_inline_javascript.php (see below)

2. test_speed.php gave me only 10 Sync Calls

Sounds like async calls are messed up something, im not actually sure what the problem would be, thats pretty much the same config I develop on (well apache 2) and things are working fine here. Are you seeing any kind of javascript errors. Also proxy_usage_inline_javascript.php has all the extra error handling turned on so it might be easier to find the problem with.

with console javascript (under FireFox 1.0.4) i got for proxy_usage_inline_javascript.php on the load page (without choose any options/links) : ---------------------------------------------------------------------------------- Erreur : missing formal parameter Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/server.php?client=Main Ligne : 20, Colonne : 33 Code Source : fullcall: function(url,encoding,class,method,callback,args) { ........................................^ ---------------------------------------------------------------------------------- Erreur : HTML_AJAX is not defined Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/proxy_usage_inline_javascript.php Ligne : 48 ---------------------------------------------------------------------------------- Erreur : HTML_AJAX_Serialize_JSON is not defined Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/server.php?client=Dispatcher Ligne : 28 ----------------------------------------------------------------------------------

What's wrong ? My config is : PEAR 1.3.5 PHP 4.3.10 on windows xp Apache 1.3.33 keep up the good work Laurent

-josh

Laurent