Re: Re: [PEPr] Changes in proposal for HTML::HTML_AJAX

bertrand Gugger wrote:

Bonjour, Joshua Eichorn wrote:

Joshua Eichorn wrote:

Joshua Eichorn (http://pear.php.net/user/jeichorn) has edited the proposal for HTML::HTML_AJAX. Change comment: A new releasing updating docblocks and coding brackets, this should be everything now Please review the proposal: http://pear.php.net/pepr/pepr-proposal-show.php?id=276

I think this gets everything Laurent and Bertrand pointed out. Though i didn't add @access public everywhere since that is the default. Also i didn't change my use of @data_dir@ since what i currently have works, data_dir seems to give you the same value specified in the pear installer not something specific to your package.

I'm terribly sorry, I was wrong in my comment, did not check entirely my references. # pear install HTML_AJAX-0.1.3.tgz install ok: channel://pear.php.net/HTML_AJAX-0.1.3 # ls /usr/share/pear/data/HTML_AJAX/ js so ... it's perfectly right, sorry. However, the "data" role is perhaps not correct here. Those files must eventually, depending on the way to load them, be on doc root. So, don't we need some other role as "public" ?

Well be default the server class provides access to the files using readfile, so im ok with the current setup for now.

Let me know if I missed anything, if I got it all i'll put it up for vote tomorrow otherwise i'll take another stab at cleanups.

I'm happy I could load and try without problems the examples on a PHP 4.2.2 server. Why do you make a dependence on 4.3 ? I agree it's sane, but what requires the package for this dependence ? à+

I think that was just the default setting in the package script i downloaded, i'll move the version down to 4.2 -josh