Re: [PEPr] Proposal for HTML::AJAX

Laurent Laville wrote:

My first review of source code: 1.You need to fix all your function declaration following coding standard http://pear.php.net/manual/en/standards.funcdef.php

well i wanted just to say : function foo() { } rather than, as you wrote, function foo() { }

Ah sure i'll get that fixed up, I was coding with the standard we use at work.

My first attempt to run the demos. 1. proxyless_usage.php do nothing, except the clear target

Odd does the proxy example work

i got same error as for proxy_usage_inline_javascript.php (see below) with console javascript (under FireFox 1.0.4) i got for proxy_usage_inline_javascript.php on the load page (without choose any options/links) : ---------------------------------------------------------------------------------- Erreur : missing formal parameter Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/server.php?client=Main Ligne : 20, Colonne : 33 Code Source :

    fullcall: function(url,encoding,class,method,callback,args) {

........................................^ ---------------------------------------------------------------------------------- Erreur : HTML_AJAX is not defined Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/proxy_usage_inline_javascript.php Ligne : 48 ---------------------------------------------------------------------------------- Erreur : HTML_AJAX_Serialize_JSON is not defined Fichier Source : http://localhost/tests/pear/users/jeichorn/HTML_AJAX-0.1.1/examples/server.php?client=Dispatcher Ligne : 28 ----------------------------------------------------------------------------------

Thats quite odd, I was actually testing things in the Firefox 1.1 alpha and they work, class is a reserved work in 1.x i'll change that to something else and do another release today. -josh