[PEPr] 0 for Math::Math_Polynomial
| From: | Arnaud Limbourg | Date: | Sat, 19 Nov 2005 13:41:44 +0000 |
| Subject: | [PEPr] 0 for Math::Math_Polynomial | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40427@lists.php.net to get a copy of this message | ||
Arnaud Limbourg (http://pear.php.net/user/arnaud) has voted 0 on the proposal for
Math::Math_Polynomial.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=312
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=312&handle=arnaud
Comment:
CS issues.
if (is_string($mixed_poly)) // Parse from string
$this -> _parsePolynomial(trim($mixed_poly));
else if (is_object($mixed_poly) and get_class($mixed_poly) ==
get_class($this)) // Load from another Polynomail
{
should be
if () {
$this->_parse
} else {
}
In short, there should be curly braces after the if statement and there
should not be spaces when calling an object's method ($this->myMethod()).
You should also use strtolower(get_class()) as get_class returns a
case-sensitive class name.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net