[PEPr] +1 for PHP::Shell
| From: | Justin Patrin | Date: | Tue, 23 May 2006 14:48:55 +0000 |
| Subject: | [PEPr] +1 for PHP::Shell | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42568@lists.php.net to get a copy of this message | ||
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for PHP::Shell.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=397
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=397&handle=justinpatrin
This vote is conditional. The condition is:
The number of votes on this package is truly amazing. Most packages lately are lucky to get the
requisite 5. Shows this is needed. Way to find something people want. :-)
My condition is:
Move the if (defined('SHELL')) stuff out of the class file. All class files should have
only the class file (and possibly register function calls like in the case of QF elements). Move
this code to a 'phpshell' script which is installed as an executable, such as the pear
install does with 'pear' (or as phpDocumentor does).
--
Sent by PEPr, the automatic proposal system at http://pear.php.net