Re: [PEPr] +1 for PHP::Shell
| From: | Lukas Smith | Date: | Tue, 23 May 2006 15:01:06 +0000 |
| Subject: | Re: [PEPr] +1 for PHP::Shell | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42569@lists.php.net to get a copy of this message | ||
Justin Patrin wrote:
Move the if (defined('SHELL')) stuff out of the class file. All class files should have only the class file (and possibly register function calls like in the case of QF elements). Move this code to a 'phpshell' script which is installed as an executable, such as the pear install does with 'pear' (or as phpDocumentor does).Whats your rational for this? Why should the constants be moved to a separate file? regards, Lukas