Re: Re: [PEPr] +1 for PHP::Shell

From: Date: Tue, 23 May 2006 17:52:14 +0000
Subject: Re: Re: [PEPr] +1 for PHP::Shell
References: 1 2 3  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-42576@lists.php.net to get a copy of this message
On 5/23/06, Lukas Smith <lsmith@php.net> wrote:
Justin Patrin wrote: Move the if (defined('SHELL')) stuff out of the class file. All class files should have only the class file (and possibly register function calls like in the case of QF elements). Move this code to a 'phpshell' script which is installed as an executable, such as the pear install does with 'pear' (or as phpDocumentor does). Whats your rational for this? Why should the constants be moved to a separate file?
Not the constant, the code. While it is somewhat useful to just have it in the class it would make more sense as an external file. -- Justin Patrin

« previous php.pear.dev (#42576) next »