[PEPr] Comment on System::Daemon

Kevin van Zonneveld (http://pear.php.net/user/kvz) has commented on the proposal for System::Daemon. Comment: Thanks for your input Joe, I've made a first attempt to implement your suggestions. I'll walk through them: 1.) Agreed. I've implemented it with/in: $usePEARLogInstance, log(), and the pearlog.php example 2.) Cause in it's current form, System_Daemon also works if you don't have PEAR on a server. Projects that only run linux & php-cli can still run the System_Daemon class. Personally I would like to maintain this duality but if this is a deal breaker I can always remove all the conditional PEAR-independent-code & make it PEAR-only. But I believe it all works like it should now. More on this case specifically: System_Daemon_Exception obviously extends PEAR_Exception, so that's the reason why I've made it conditional. And checking for it's existence seemed elegant because Autoload should make sure the System_Daemon_Exception is included automatically and is always thrown if the class was running in PEAR-mode. 3.) Agreed. I've changed the log constants to match PEAR_Log's values. I do still use a duplicate set though, for reasons described in (2), but the constants' values are interchangeable now so I think that should offer adequate compliance. 4.) I had hoped requiring PHP 5 >= 5.1.2 would solve this issue. I don't know PEAR's official stance in the autoload matter, I could not find it in the documentation. But I've seen the PHP_CodeSniffer package use it and so I figured it would be okay? 5.) Fixed, the trigger_error can now only be executed when in non-PEAR-mode. Again, if PEAR developers like yourself have considerable problems with this 'duality', let me know. 6.) Agreed. I've implemented it with $iniSettings, and added a safe_mode check like you suggested. 7.) Agreed. I've implemented it with setSigHandler() Further comments on for improvement are more than welcome. And if you (or anyone else) would like to discuss the implementation of a change in depth; please feel free to contact me on a messenger: http://kevin.vanzonneveld.net/about/. Of course, requests for changes themselves would have to be discusses in PEPR I think. (not a native English speaker so I hope everything is clear) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=553 -- Sent by PEPr, the automatic proposal system at http://pear.php.net