Re: [PEPr] +1 for System::Daemon

On Sun, May 11, 2008 at 12:51 PM, Till Klampaeckel <till@php.net> wrote: > * I'd phase out OS-specifics into a driver architecture, e.g.: That's a good idea, but I need to give it some more thought on how to implement that elegantly. I'll keep you posted on that one. > * PEAR_Exception should be included from the Exception file (PEAR.php is > not necessary.) Is handled by SPL. Borrowed the idea from PHP_CodeSniffer, but I don't know PEAR's official stance on that mechanism yet. > * simplify if/else where possible (e.g., when you throw in an if, you need > no else) Done. > * I'd like to see less public variables and (maybe) __get/__set instead. Done. Now handled by a setOption-like architecture. Still needs a little polishing though. > * Your tests should be added to a "tests/" dir and also in package.xml Done. > * Log should be an optional dependency Done. Only I cannot update the proposal's page when calling for votes -- Kind regards, Kevin van Zonneveld Work | http://www.true.nl/ About | http://kevin.vanzonneveld.net/