[PEPr] +1 for System::Daemon

From: Date: Sun, 11 May 2008 10:51:10 +0000
Subject: [PEPr] +1 for System::Daemon
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-50080@lists.php.net to get a copy of this message
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for System::Daemon. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=553 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=553&handle=till Comment: I second Michael Gauthier's thoughts. Here are some more: * I'd phase out OS-specifics into a driver architecture, e.g.: System_Daemon_Os_Debian System_Daemon_Os_Windows System_Daemon_Os_Darwin ... * PEAR_Exception should be included from the Exception file (PEAR.php is not necessary.) * simplify if/else where possible (e.g., when you throw in an if, you need no else) * I'd like to see less public variables and (maybe) __get/__set instead. * Your tests should be added to a "tests/" dir and also in package.xml (role="test"), see other packages for examples. * Log should be an optional dependency I also find the "usePEAR" stuff rather misleading, is this necessary since you are proposing to PEAR? I am not sure why all those conditionals are in the code. For example, you have code checking for exception classes, etc.. I would just make sure it loads them properly ("require_once 'System/Os/Exception.php';") and be done with it. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#50080) next »