[PEPr] +1 for Semantic Web::XML_GRDDL

From: Date: Sat, 03 May 2008 21:21:10 +0000
Subject: [PEPr] +1 for Semantic Web::XML_GRDDL
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49993@lists.php.net to get a copy of this message
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Semantic Web::XML_GRDDL. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=533 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=533&handle=gauthierm Comment: Looks good. The only complaints I have are coding standards related. The package itself looks interesting and is something I can see myself using at some point but never want to have to write myself ;) I appreciate the documented examples on Google Code. Source comments: 1. missing ?> at the end of files 2. some class members are not documented. Given the large source base and large amount of work it is to document everything I don't think this should prevent a vote but it should be fixed up before a stable release. 3. PEAR's member variable naming conventions are camelCase, not under_scores. 4. methods that return nothing should be documented as @return void, not @return. 5. try running the code through phpcs. It's not bulletproof but it usually turns up small edge-case PEAR coding style issues. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49993) next »