[PEPr] +1 for Semantic Web::XML_GRDDL
| From: | Till Klampaeckel | Date: | Sun, 04 May 2008 11:21:10 +0000 |
| Subject: | [PEPr] +1 for Semantic Web::XML_GRDDL | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50001@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Semantic
Web::XML_GRDDL.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=533
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=533&handle=till
This vote is conditional. The condition is:
Very clean code, great proposal.
Otherwise I am with cweiske (regarding the absolute path).
My only objection (hence the conditional) is that you did not create your own exception class.
To fix that, add XML/GRDDL/Exception.php with:
require_once 'PEAR/Exception.php';
XML_GRDDL_Exception extends PEAR_Exception
{}
and fix all your throw's.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net