[PEPr] +1 for Payment::PagamentoCerto
| From: | David Jean Louis | Date: | Wed, 31 Dec 2008 11:22:47 +0000 |
| Subject: | [PEPr] +1 for Payment::PagamentoCerto | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51371@lists.php.net to get a copy of this message | ||
David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for
Payment::PagamentoCerto.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=583
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=583&handle=izi
Comment:
Code looks good, nice to see you already have tests.
I don't know pagamentocerto so I cannot comment a lot ;)
Just a note: your source layout is a bit weird, I think it would be better
to have something like:
rootdir/
|__ Payment/
|__ |__ PagamentoCerto.php
|__ |__ PagamentoCerto/
|__ |__ |__ Exception.php
|__ |__ |__ Order.php
|__ |__ |__ etc...
|__ tests/
|__ examples/
|__ package.xml
--
Sent by PEPr, the automatic proposal system at http://pear.php.net