[PEPr] +1 for Payment::PagamentoCerto
| From: | Michael Gauthier | Date: | Sat, 03 Jan 2009 21:04:54 +0000 |
| Subject: | [PEPr] +1 for Payment::PagamentoCerto | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51387@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for
Payment::PagamentoCerto.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=583
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=583&handle=gauthierm
Comment:
Great code. I still think you should use an XML API to generate the XML,
but as you said, it's on your todo list!
The documentation for constants should be one doc-block per constant. I
think there is a shorthand syntax to indicate that the documentation
applies to more than one constant. Chuck might know it off the top of his
head.
Having all exceptions in one file is allowed in PEAR1 as far as I know. I
think it is explicitly forbidden in PEAR2 (due to the autoloading
conventions).
--
Sent by PEPr, the automatic proposal system at http://pear.php.net