[PEPr] +1 for Payment::PagamentoCerto
| From: | Bill Shupp | Date: | Sun, 04 Jan 2009 17:23:58 +0000 |
| Subject: | [PEPr] +1 for Payment::PagamentoCerto | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51391@lists.php.net to get a copy of this message | ||
Bill Shupp (http://pear.php.net/user/shupp) has voted +1 on the proposal for
Payment::PagamentoCerto.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=583
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=583&handle=shupp
Comment:
Very nice code. I do agree with the other vote comments, and would like
to add a couple of my own:
1) I think employing the pattern Michael recommended in his proposal
comment for early returns / Exceptions will rid your code of a *lot* of
else statements.
2) Why do you have an empty constructor in Payment_PagamentoCerto_Order?
It's not overwriting anything. Just remove it.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net