[PEPr] +1 for Payment::PagamentoCerto

Daniel O'Connor (http://pear.php.net/user/doconnor) has voted +1 on the proposal for Payment::PagamentoCerto. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=583 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=583&handle=doconnor This vote is conditional. The condition is: 1) http://github.com/ppadron/pagamentocerto/tree/master/Payment/PagamentoCerto/PagamentoCerto.php should shift up one level. IE, it should be require_once 'Payment/PagamentoCerto.php'; 2) More heckling re AllTests.php - http://lauken.com/doconnor/ in where the unit tests live, even if they are a smidge broken at the moment 3) The unit tests should inject a fake soap client which returns dummy results. Something like: $client = new MockSoapPaymentPagamentoClient(); $client->addResponse(array(1, 2, 3)); $foo = new Payment_PagamentoCerto($client); $foo->setClient($client); assert($foo->bar() == array(1, 2, 3)); It should also cover off negative test cases - ie, raising exceptions on a HTTP 404 / 403 / 505. Other than that, LGTM! -- Sent by PEPr, the automatic proposal system at http://pear.php.net