[PEPr] +1 for Payment::PagamentoCerto
| From: | Till Klampaeckel | Date: | Sat, 03 Jan 2009 16:59:56 +0000 |
| Subject: | [PEPr] +1 for Payment::PagamentoCerto | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51386@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for
Payment::PagamentoCerto.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=583
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=583&handle=till
Comment:
Sorry that this took a while, the holidays got in the way. ;-)
Anyway, extremely clean code, very well done. I second David -- I don't
know much about this payment processor either.
While I see the advantage of putting all Exceptions into the same file, I
also think this breaks the class<->file layout, so I'm torn on that. Maybe
the PEAR overlords can comment if this is "allowed".
I have some minor edits, so I forked your repo on Github -- have a look,
the changes are not conditional, just food for thought!
<http://github.com/till/pagamentocerto/commit/75bc90c5c35bae9ea09edabfe1a21ac0c742aeb6>
--
Sent by PEPr, the automatic proposal system at http://pear.php.net