Re: DBA - closing in on an initial release (fwd)
| From: | Martin Jansen | Date: | Sun, 07 Jul 2002 10:23:10 +0000 |
| Subject: | Re: DBA - closing in on an initial release (fwd) | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-7524@lists.php.net to get a copy of this message | ||
On Sat Jul 06, 2002 at 11:1939PM -0500, Brent Cook wrote:
> May I ask for a little peer review and package-releasing magic on the pear
> website? Thanks. I hope that someone finds this useful besides me.
You sometimes seem to use
if (foo)
{
$baz = 'abc';
}
where
if (foo) {
$baz = 'abc';
}
would be appropriate. Additionaly you sometimes use
function bar ()
{
}
where the space between the function name and the parenthesis is not
necessary. The same applies for some other cases in your code. (IIRC
you also used "return ('foo')", where the space is also not
necessary.
Well, actually these points are more or less minor things. Generally
speaking, your code looks pretty much pearified and you should release
a first version so that people can start playing with it. If you need
advise on how to roll a release, just ask here.
- Martin
--
Martin Jansen - mail@martin-jansen.de
http://martinjansen.com/