Re: DBA - closing in on an initial release (fwd)

> 1) With peardoc, should we use "@return" or "@returns" to signify what a > method or function returns. I ran my code through phpdocumentor, and was > surprised to see that it uses both, but in different ways. So, my code > uses "@return" to signify the data _type_ returned and "@returns" to > describe that data (e.g. an array of records, etc.) > > A simple function might have this: > > * @return boolean > * @returns true on success, false on failure > > Does anyone have comments on this? It seems that following the format of > @param would make more sense, e.g. > > * @returns boolean true on success, false on failure OK, I settled on @return, since that's what's used in the rest of PEAR, phpdocumentor be damned ;) > 2) I am having issues with PEAR destructors. They work fine with DBA and > its drivers, but do not work with DBA_Table or DBA_Relational. I just > can't see what I did differently, other than DBA using a factory method > for creating new objects and creating tables and databases with =& new. > The problem is reproducible if you uncomment the echo statements in the > destructors and run test_relational.php. One should see several DBA > objects melt, several DBA_Tables melt and one DBA_Relational melt. So far, > only the DBA objects melt. Fixed this - the code didn't call the base constructor for PEAR. Base class constructors are apparently called automatically if you don't define a constructor for a child class, but not if you do. I guess that solves all of my problems. - Brent