Re: Virtual Filesystem
| From: | Chuck Hagenbuch | Date: | Tue, 24 Sep 2002 19:49:41 +0000 |
| Subject: | Re: Virtual Filesystem | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-9443@lists.php.net to get a copy of this message | ||
Quoting Jon Wood <jon@jellybob.co.uk>:
> I think I've finished stripping out the Horde API references from the VFS
> class - you can take a look at what I've got so far at
> www.thewoods.org/~jon/vfs.php.
Since you only made the highlighted source available (hard to get back to
the clean source from all of the inserted space and HTML), I didn't do a
diff, but I think I've replicated most of your changes in Horde CVS
(http://cvs.horde.org/cvs.php/horde/lib/VFS/), as well as fixed a few things
you did - you were doing PEAR::raiseError() in the _connect() functions, but
never stopping if there was an error.
What you didn't remove were several calls to Horde::getTempFile(), which is
a utility method that we have to safely get a temporary file. I'd rather not
just duplicate it in the VFS class; how do you propose to take care of this
functionality?
Also, for those who are interested, I also committed alpha-level Oracle
support to the SQL driver; someone who actually uses Oracle should test it out.
-chuck
--
Charles Hagenbuch, <chuck@horde.org>
"After a few minutes the most aromatic and nice smelling Italian coffee
will come out of the exhaustpipe." - Our stove-top espresso pot