Re: [pear-webmaster] pear-testing malinglist

Hi Daniel Convissor! On 06/15/04 18:55 you wrote:

The function idea sounds bad to me. Many places to change it, because mail() can not be overwritten (AFAIK).

No need to overwrite the function. Just make a new function named pearweb_mail() that accepts the same arguments as mail(). Then search and replace on mail(). Pretty simple.

Evem search and replace is always a risk. :) So, why not walk the secure way and just define the mailadresses depending on the environment?

Anyway, that does not solve the problem, that if someone codes a new feature for PEARWeb and want's it to be tested by the public, they cannot test the mailings

Sure they can. Make the pearweb_mail() configurable to allow actual emails to go out if the proper options are set. Perhaps even make that option an array, so only designated scripts will be able to send real mails while others don't.

I don't think a pear-test list would work because the addresses are often hard coded in the various scripts rather than using any preset constants. This is particularly true on bug reports, where the devs and reporters would be getting emailed.

Which is a manko of the bug system. ;) Nevertheless. As you may have seen, I opened an IMAP account and offered access to it by webmail to show people the comment system emails, which was a high security risk for myself. A test list would have solved that like a charme. IMHO it should be easy to find out, where the specific mailings are in the bug tracker to change them. In that case we can even change it to use the new Damblan_Mail class I created, which could check for DEV-BOX and email the test list instead of all real mail adresses. :) Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info