Re: [pear-webmaster] pear-testing malinglist

Hi Daniel Convissor! On 06/16/04 02:19 you wrote:

You can come up with a better argument than that. mail() is only used 14 times, spanning seven files. That's a piece of cake. The search/replace can be done with a regex search and manual replacement. Here's the regex I used to come up with the calculation:

    grep -rE '([^a-zA-Z_])mail\(' .

Err. PEPr uses some constant mail addresses. ;-P

So, why not walk the secure way and just define the mailadresses depending on the environment?

The addresses aren't centralized. None of the 14 calls to mail use any predefined addreses. Nor can most of them be configured to do so.

True. They aren't, usually.

In that case we can even change it to use the new Damblan_Mail class I created, which could check for DEV-BOX and email the test list instead of all real mail adresses. :)

I thought you said you don't want to search/replace? :) Anyway, where can we take a look at it?

K, you're right, that mail class is pretty much the same as a custom mail function. Also it's main purpose is templating mails. See www.schlitt.info/misc/pearweb.tar.gz for complete source of the comment system + Damblan_Mail. Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info