Re: cvs: pearweb /public_html/trackback trackback-admin.php
| From: | Pierre | Date: | Sat, 22 Oct 2005 10:20:24 +0000 |
| Subject: | Re: cvs: pearweb /public_html/trackback trackback-admin.php | ||
| References: | 1 2 3 | Groups: | php.pear.cvs php.pear.webmaster php.pear.core |
| Request: | Send a blank email to pear-webmaster+get-4536@lists.php.net to get a copy of this message | ||
On Fri, 21 Oct 2005 22:43:55 -0400
cellog@php.net (Greg Beaver) wrote:
> 1) if you haven't tested the code, don't commit it
> 2) if you can't test it, post a patch to pear-webmaster
> 3) if you've tested it, commit it
> 4) if it's obvious you haven't tested it, you get a warning. On the
> second commit of obviously untested code, your cvs karma is revoked
> for 4 weeks, minimum.
5) if you have no idea about the reasons, ignore or ask
I'm not going to test each single page to see if one did his work
correctly or not. A security reason (very critical) made me set
register globals to off. I tested 7-80% of the site and it works.
It was more time efficient to do it this way, and the only 2 complaints
are fine with me. If you (all together) have nothing else to do that
shooting at the sherif, please do, but I doubt it helps in any way to
make this code base better or safer.
--Pierre