Re: Re: [pear-webmaster] Re: cvs: pearweb /public_html/trackback trackback-admin.php

anatoly techtonik wrote: > Hello Greg, > > A bit ironic, as always. > > >>>> # Guess who broke it ... >>> >>>I think I did, while trying to fix/clean/secure this horrible thing. >>> >>>But seems to be very used.... The gulty commit is certainly this one: >>> $Id: trackback-admin.php,v 1.7 2005/01/29 17:46:33 pajoye Exp $ >>> >>>But well, who cares anyway? > > > GB> I think the answer to this is anyone who experiences a broken webpage as > GB> a result, no? > > GB> The point is that as core PEAR developers, we are held to the same > GB> standard that others are. > > GB> I think the best thing to do is to test prior to commit, or to post a > GB> patch and ask for testing if it's not possible to test. Committing a > GB> broken patch is far worse than not committing a possible fix. > > Yes, Greg - that's all good in theory. Have you tried to test it yourself? Yes I have. You have to click through every page (with display_errors on and so on), and try uploading/deleting releases. It takes 5 minutes. I do it every time I commit something to pearweb. Greg