Re: export symbols patch

Pierre wrote: > On Jan 12, 2008 2:42 AM, Gregory Beaver <greg@chiaraquartet.net> wrote: > > Hi Greg, > > >> I think you may be right about PHPAPI since it only applies to windows, >> I will try on my windows machine before I commit, thanks for the branch >> list, and if one does happen to be forgotten, just let me know and I'll >> apply it there too. >> > > I re check the list, every active branch has been modified, thanks again :) > > >> Incidentally, I'll probably just use BEGIN_EXTERN_C instead of my patch >> since it's defined in the same header file as PHPAPI >> > > Yes, it makes sense. Have you tested it already under windows? If yes > and if it works as expected, I can release it tonight. I have, but I would prefer that someone else independently verify the work prior to release, as I only have a 32-bit machine, and always feel better if 2 people try a change like this out. Greg