Re: export symbols patch
| From: | Gregory Beaver | Date: | Sat, 12 Jan 2008 14:58:06 +0000 |
| Subject: | Re: export symbols patch | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5058@lists.php.net to get a copy of this message | ||
Johannes Schlüter wrote:
> Hi,
>
> On Sat, 2008-01-12 at 01:57 +0100, Pierre wrote:
>
>>> Turns out, the only thing missing was the extern declaration in zipint.h
>>>
>> Don't we need to export the functions on windows? That's what we do
>> for the other functions (PHP_API, ZEND_API or xml equivalents).
>>
>
> Won't it make sense to prefix exported symbols with php_ or something to
> prevent conflicts with other Apache modules having a zip_open symbol?
I could of course do this relatively easily with a search/replace, but
it would be a very extensive modification to the source of libzip as
well as to both pecl/phar and pecl/zip, so I would want further opinions
before taking the leap.
Greg