Re: export symbols patch

Pierre wrote: > Hi Greg, > > Thanks for the patch! > > On Jan 12, 2008 1:45 AM, Gregory Beaver <greg@chiaraquartet.net> wrote: > >> Hi all, >> >> Turns out, the only thing missing was the extern declaration in zipint.h >> > > Don't we need to export the functions on windows? That's what we do > for the other functions (PHP_API, ZEND_API or xml equivalents). > > It will work without if you compile zip statically with php but I'm > not sure it works when zip is compiled as shared. We also need to > install the headers and .a/.lib on unix platforms, for example if one > likes to compile against it too. It works with the external include > now because it is binary compatible (it should remain so until large > support and streams are in place). > > Anyway, you can already apply this patch to pecl HEAD (targetting 2.x > with the big internal changes), PECL_1_8 (stable branche, the one I > can release shortly), php 5.3 and head. If Ilia is ok, feel free to > apply it to 5_2 as well, I think I did not forget a branch :-D Hi Pierre, I think you may be right about PHPAPI since it only applies to windows, I will try on my windows machine before I commit, thanks for the branch list, and if one does happen to be forgotten, just let me know and I'll apply it there too. Incidentally, I'll probably just use BEGIN_EXTERN_C instead of my patch since it's defined in the same header file as PHPAPI Thanks, Greg