Re: Re: export symbols patch
| From: | Pierre | Date: | Sat, 12 Jan 2008 21:35:53 +0000 |
| Subject: | Re: Re: export symbols patch | ||
| References: | 1 2 3 4 5 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5064@lists.php.net to get a copy of this message | ||
On Jan 12, 2008 4:32 PM, Johannes Schlüter <johannes@php.net> wrote:
> Hi,
>
> On Sat, 2008-01-12 at 08:58 -0600, Gregory Beaver wrote:
> > I could of course do this relatively easily with a search/replace, but
> > it would be a very extensive modification to the source of libzip as
> > well as to both pecl/phar and pecl/zip, so I would want further opinions
> > before taking the leap.
>
> The other way would be to do this by #defines, like we do in
> main/php_compat.h for gd, pcre and other bundled libs so they can easily
> updated.
Yes, I would rather prefer this way. It is transparent and allow me to
send fixes and patches to the external library (which is not
compatible yet).
--
Pierre
http://blog.thepimp.net | http://www.libgd.org