Re: Re: export symbols patch

On Sat, 12 Jan 2008, Gregory Beaver wrote: > Johannes Schlüter wrote: > > > > On Sat, 2008-01-12 at 01:57 +0100, Pierre wrote: > > > >>> Turns out, the only thing missing was the extern declaration in zipint.h > >>> > >> Don't we need to export the functions on windows? That's what we do > >> for the other functions (PHP_API, ZEND_API or xml equivalents). > > > > Won't it make sense to prefix exported symbols with php_ or something to > > prevent conflicts with other Apache modules having a zip_open symbol? > > I could of course do this relatively easily with a search/replace, but > it would be a very extensive modification to the source of libzip as > well as to both pecl/phar and pecl/zip, so I would want further opinions > before taking the leap. For another lib (can't find which one quickly) we solve this renaming by including a file with macros to redefine the names. Then no extensive modifications are required. regards, Derick