Re: Lowercase or camelcase function names?
| From: | Johannes Findeisen | Date: | Mon, 14 Nov 2011 20:28:08 +0000 |
| Subject: | Re: Lowercase or camelcase function names? | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-8859@lists.php.net to get a copy of this message | ||
On Sat, 12 Nov 2011 02:02:55 +0100
Johannes Schlüter <johannes@schlueters.de> wrote:
> On Tue, 2011-11-08 at 02:28 +0100, Johannes Findeisen wrote:
> >
> > The definition of "LONG" is in the same file. The first definition was
> > for __APPLE__ :/ I found this for "else" OS's:
> >
> > typedef long LONG;
>
> That is fine, the int32_t on Windows is fine, too. One thing one might
> think about for making the code clear is try to separate LONG-usage in
> pcsc context from long in PHP context and probably using explicit
> (long) /(LONG) casts. But I'm not sure whether, in this case, it helps
> reading the code or makes it worse.
>
Hmm,
since it is defined in the PC/SC API, I think we should
leave it as it is... But I am not shure too.
Johannes