Re: User Profile Modifications
| From: | Hannes Magnusson | Date: | Tue, 30 Jun 2009 07:45:29 +0000 |
| Subject: | Re: User Profile Modifications | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-5167@lists.php.net to get a copy of this message | ||
On Tue, Jun 30, 2009 at 03:26, Paul Dragoonis<dragoonis@gmail.com> wrote:
> I've made improvements to the user.php page displaying user information.
> I have supplied a patch script of the user.php and styles.css files and the
> following url is a screenshot of what the changes look like.
> Tested in the latest Safari, Firefox and IE7/IE8.
> http://digiflexdev.com/php/php_people.png
>
The look looks great, the markup however looks like crap.
Could try to adapt the patch to use the existing elements on the page,
and stay away from any and all markup that only has visual meaning
(<div style="clear: both"> </div> f.e. is a big fat no no).
-Hannes
