Re: User Profile Modifications
| From: | Hannes Magnusson | Date: | Tue, 30 Jun 2009 13:31:18 +0000 |
| Subject: | Re: User Profile Modifications | ||
| References: | 1 2 3 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-5192@lists.php.net to get a copy of this message | ||
On Tue, Jun 30, 2009 at 14:10, Paul Dragoonis<dragoonis@gmail.com> wrote:
> The changes are now complete, the original tags are now in place with extra
> styling to make it more appealing.
> Patch File: http://digiflexdev.com/php/php-people-web.patch
Whats the point of adding the same class to all <dt> and another to all <dd>?
Can't the CSS reference these directly?
If you think those styles will break other definition lists, then lets
add an ID on the <dl> element itself.
+ <h2 id="notes" style="color: #5A5993;">Notes:</h2>
This is totally useless, please move it into the css referencing the ID
And please do not mix WS changes with real fixes, it makes it very
hard to review patches and track the history.
-Hannes